Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just update to v2.1.7 and the found some error #17

Closed
mene078 opened this issue Nov 9, 2017 · 6 comments
Closed

Just update to v2.1.7 and the found some error #17

mene078 opened this issue Nov 9, 2017 · 6 comments

Comments

@mene078
Copy link

mene078 commented Nov 9, 2017

I got the error from my angular app, which just an update for today. Can not find any reference one for now.

Error: Unexpected value 'Ng2ImgMaxModule' imported by the module 'AppModule'. Please add a @NgModule annotation

@mene078 mene078 closed this as completed Nov 9, 2017
@bogacg
Copy link

bogacg commented Nov 9, 2017

You've closed this issue but I'm seeing same error.

@bergben bergben reopened this Nov 9, 2017
@bergben
Copy link
Owner

bergben commented Nov 9, 2017

This indeed is a currently active bug, compare bergben/ng2-img-tools#22

@mene078
Copy link
Author

mene078 commented Nov 9, 2017

Yes, I closed this issue because I think that’s not the plugin bug. This issue happen with my action that tried to update from angular 4.5~ to 5.
Not just this lib had the issue, so I decided to downgrade my currently working project back to 4.5~.

@pegaltier
Copy link

pegaltier commented Nov 9, 2017

Same bug since ng2-img-max 2.1.7 and 2.1.8 and angular 5.0.0 and 5.0.1
Temporary patch: use 2.1.6 version and patch with my solution: #15
without this patch it work in dev mode but it's mandatory in order to build in production mode
work with angular 5.0.0 and 5.0.1

@dgaletto
Copy link
Contributor

If you want to continue developing you can try ng serve --aot

I'm busy this week, but I'll try to help with the error.

@bergben
Copy link
Owner

bergben commented Nov 16, 2017

Hi guys, thanks for your patience. I just fixed this in 2.1.9.
Turns out you have to set typescript to version 2.4.2 in package.json, as never versions of TS don't work with ngc yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants