test_deck_present failing

[ataffanel]

The test_deck_present test is failing with the error:

        for deck in test_setup.device.decks:
>           assert deck in discovered
E           AssertionError: assert 'bcLighthouse4' in []

I cannot reproduce the problem in my end, it fails on assert test_setup.device.connect_sync() for me.

I am going to push a change that skips this test for now so that we can keep testing the rest.

[jonasdn]

So, I can reproduce this, by going from the rpi:

CRAZY_SITE=crazylab-malmö py.test-3 --verbose tests/QA/test_decks.py

But only if the following commit is not reverted: bitcraze/crazyflie-lib-python@e54c065

So something needs to be fixed there!

[jonasdn]

The following patch seem to fix that test:

diff --git a/tests/QA/test_decks.py b/tests/QA/test_decks.py
index 59f2232..c0e5b34 100644
--- a/tests/QA/test_decks.py
+++ b/tests/QA/test_decks.py
@@ -40,15 +40,13 @@ class TestDecks:
             if int(value) == 1:
                 discovered.append(name.rsplit('.')[-1])  # deck.name => name
 
-        assert test_setup.device.connect_sync()
-
         test_setup.device.cf.param.add_update_callback(
             group='deck',
             name=None,
             cb=deck_param_callback
         )
 
-        time.sleep(3)
+        assert test_setup.device.connect_sync()
 
         for deck in test_setup.device.decks:
             assert deck in discovered

Are we breaking API? Since I do not think we require subscribing to update callbacks after connect before this commit?

[jonasdn]

The basicparam.py example breaks by the commit above as well, since it connects before setting the callback.