Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds28e05 driver does not write correctly to memory multiplications of 16B #89

Open
coopper5120 opened this issue Mar 12, 2023 · 2 comments
Labels

Comments

@coopper5120
Copy link

When testing communication with ds28e05, I found following bug:

REPRODUCTION PROCEDURE:
Set addres to write at 0x00. Write 32B of data.

RESULT:
Only 16B is actually written.

EXPECTED RESULT:
Full 32B is written.

PROPOSITION OF SOLUTION:
Function ds28e05WriteMemory():
This:
if ((length - wBytes) >= (BYTES_PER_PAGE))
instead of this:
if ((length - wBytes) > (BYTES_PER_PAGE))

This soultion was tested with writing 32B into memory.
All bytes was actually written.

@coopper5120 coopper5120 changed the title ds28e05 driver does not write correctly to memory multiplications of 16 bytes ds28e05 driver does not write correctly to memory multiplications of 16B Mar 12, 2023
@knmcguire knmcguire added the bug label Mar 13, 2023
@knmcguire
Copy link
Contributor

Thanks for notifying us! We will discuss this at our next triage meeting next week.

@knmcguire
Copy link
Contributor

@coopper5120 could you perhaps make a PR based on your suggestion? That sounds alright to us.

If you don't have time for that, let us know as well and one of us will do it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants