Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Captivate not save the Target Hostname/IP and port #2

Open
2 tasks done
Max71123421432134e312 opened this issue Oct 3, 2024 · 7 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@Max71123421432134e312
Copy link

Is this a bug in companion itself or a module?

  • I believe this to be a bug in companion

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Hi, I have the ussue with Captivate (Newblue) and companion
When the restart windows the Target Hostname/IP an the port is blank.
ip

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS:
- Browser:
- Companion Version:

Additional context

No response

@Max71123421432134e312 Max71123421432134e312 added the bug Something isn't working label Oct 3, 2024
@krocheck
Copy link
Member

krocheck commented Oct 3, 2024

@Max71123421432134e312 please fill in the environment details section of the bug so a proper attempt to reproduce and fix can be made. I was not able to reproduce on v3.4.1 mac-arm using Firefox.

@Max71123421432134e312
Copy link
Author

Environment (please complete the following information)

  • OS: Windows 11
  • Browser: CHROME
  • Companion Version: [v3.4.1
  • Captivate Titler live new blue : 5.10.240710
    Thanks.
    PS: I tried the companion version 3.3.1 it's the same issue.

@krocheck
Copy link
Member

krocheck commented Oct 3, 2024

Can you provide the data values you're attempting to enter. There could be a regex validation problem. If you need to privately send those, let me know.

@Max71123421432134e312
Copy link
Author

The defoult is 127.0.0.1 port 9023 and works

@Max71123421432134e312
Copy link
Author

VMIX is the same IP addres but change the Port and works. if change the VMIX Ip addres it save the data
image

@krocheck
Copy link
Member

krocheck commented Oct 3, 2024

I'm going to flag this block of code in captivate.js as the problem and send this issue over to the module, as it clearly makes no sense that the module would clear out host and port because of an error in the connection.

		socket.on('error', (data) => {
			this.updateStatus(InstanceStatus.BadConfig)
			this.log('warning', `NewBlue: Captivate: Connection error ${data}.`)
			this.status && this.status(this.STATUS_WARNING, 'Disconnected')
			this.config.needsNewConfig = true
			this.config.port = ''
			this.config.host = ''
		})

Here's logs showing a save and the values getting cleared out:

debug: connection needs new configuration
debug: {"host":"","port":"","needsNewConfig":true,"bonjour_host":null}
debug: connecting to null
debug: "Configuration Changed"
debug: {
  "host": "127.0.0.1",
  "port": 9023,
  "needsNewConfig": false,
  "bonjour_host": null
}
debug: {"host":"127.0.0.1","port":9023,"needsNewConfig":false,"bonjour_host":null}
debug: connecting to ws://127.0.0.1:9023
debug: connection needs new configuration
debug: {"host":"","port":"","needsNewConfig":true,"bonjour_host":null}
debug: connecting to null

@krocheck krocheck transferred this issue from bitfocus/companion Oct 3, 2024
@Max71123421432134e312
Copy link
Author

Hello, is it solved the issue ?

Thanks
Massimo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants