Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback to 'image_url' if 'animation_url' is invalid for NFT instance #1669

Closed
yvaskov opened this issue Mar 4, 2024 · 2 comments · Fixed by #1670
Closed

Add fallback to 'image_url' if 'animation_url' is invalid for NFT instance #1669

yvaskov opened this issue Mar 4, 2024 · 2 comments · Fixed by #1670
Assignees
Labels
bug Something isn't working v1.25.2 Release v1.25.2 v1.26.0 Release v1.26.0

Comments

@yvaskov
Copy link
Contributor

yvaskov commented Mar 4, 2024

Description

We are currently prioritizing animation_url before image_url without a fallback option.

In this example animation_url from the instance metadata has invalid content, hence we show no image, even with image_url present:
https://explorer.immutable.com/token/0x848cDb63B09490189E8D9779b5aE7782dA9A40EE/instance/45186
https://metadata.guildofguardians.com/api/v1/nfts/0x848cdb63b09490189e8d9779b5ae7782da9a40ee/45186

Need to implement a fallback option to image_url when animation_url content is invalid.

@yvaskov yvaskov added the bug Something isn't working label Mar 4, 2024
@yvaskov
Copy link
Contributor Author

yvaskov commented Mar 4, 2024

Assigned critical severity as it impacts Immutable mainnet collections

@tom2drum tom2drum self-assigned this Mar 4, 2024
@tom2drum
Copy link
Collaborator

tom2drum commented Mar 4, 2024

also we can add support for .m3u8 files
example

UPDATE: will do in a separate task #1671

@github-actions github-actions bot added the v1.25.2 Release v1.25.2 label Mar 5, 2024
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.26.0 Release v1.26.0 and removed pre-release Tasks in pre-release right now labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1.25.2 Release v1.25.2 v1.26.0 Release v1.26.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants