From 6566e829672f8054ac51d382d941d3e63bbdb5ba Mon Sep 17 00:00:00 2001 From: Alexgao001 Date: Wed, 24 Jul 2024 17:28:22 +0800 Subject: [PATCH] fix: hide err details --- restapi/handlers/blob.go | 6 +++--- service/error.go | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/restapi/handlers/blob.go b/restapi/handlers/blob.go index d6340d0..1ae9e5a 100644 --- a/restapi/handlers/blob.go +++ b/restapi/handlers/blob.go @@ -45,7 +45,7 @@ func HandleGetBlobSidecars() func(params blob.GetBlobSidecarsByBlockNumParams) m } sidecars, err = service.BlobSvc.GetBlobSidecarsByRoot(hex.EncodeToString(root), indicesInx) if err != nil { - return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err)) + return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError()) } } else { slot, err := util.StringToUint64(blockID) @@ -54,7 +54,7 @@ func HandleGetBlobSidecars() func(params blob.GetBlobSidecarsByBlockNumParams) m } sidecars, err = service.BlobSvc.GetBlobSidecarsByBlockNumOrSlot(slot, indicesInx) if err != nil { - return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err)) + return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError()) } } payload := models.GetBlobSideCarsResponse{ @@ -99,7 +99,7 @@ func HandleGetBSCBlobSidecars() func(params blob.GetBSCBlobSidecarsByBlockNumPar } sidecars, err := service.BlobSvc.GetBlobSidecarsByBlockNumOrSlot(blockNum, nil) if err != nil { - return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalErrorWithError(err)) + return blob.NewGetBlobSidecarsByBlockNumInternalServerError().WithPayload(service.InternalError()) } // group sidecars by tx hash bscTxSidecars := make(map[string]*models.BSCBlobTxSidecar) diff --git a/service/error.go b/service/error.go index 8f856fc..8a3096f 100644 --- a/service/error.go +++ b/service/error.go @@ -26,10 +26,10 @@ func (e Err) Error() string { return fmt.Sprintf("%d: %s", e.Code, e.Message) } -func InternalErrorWithError(err error) *models.Error { +func InternalError() *models.Error { return &models.Error{ Code: 500, - Message: err.Error(), + Message: "internal error", } }