Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Lab functionality #23

Open
DLimited opened this issue Feb 13, 2022 · 2 comments
Open

Further Lab functionality #23

DLimited opened this issue Feb 13, 2022 · 2 comments

Comments

@DLimited
Copy link

Hey there,

I plan to spend a month or so diving into this project both to teach myself (more) python and to include some functionality I'd love to have for next leaguestart.

More specifically, I want to add OAuth Login so Labbie can pull stash tab data; and a way to store Item Name + Positon along with the needed enchant and pricetag for lab services. Ideally I'd want Labbie to be able to scan which enchants are offered, then pinpoint me to exactly which item(s) need that enchant and show me how much I'm getting paid for it.

Additionally, I'd want to be able to click a "scan" button, that then parses through my stash tabs and tells me which bases I am short on and need to stock up again.

I do now know what your exact vision is for Labbie, so I'd like to know if I should hack this together so it works for me, or make it pretty and readable for eventual merging.

@bnorick
Copy link
Owner

bnorick commented Feb 13, 2022

That's definitely planned functionality and I'd be happy to have help. I'm also planning trade API integration to do in app price checks, perhaps that can use the OAuth login as well. I typically just use POESESSID for stash and trade API access, I've not used the OAuth approach yet.

@Xandaros
Copy link

Something to keep in mind is that the OAuth login is going to require an authentication server hosted by you. GGG takes the words "client secret" seriously and won't let you distribute it in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants