Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtcOffset should reject when the offset is subminute precision. #230

Open
nekevss opened this issue Mar 2, 2025 · 1 comment
Open

UtcOffset should reject when the offset is subminute precision. #230

nekevss opened this issue Mar 2, 2025 · 1 comment
Labels
C-internal Internal library improvements

Comments

@nekevss
Copy link
Member

nekevss commented Mar 2, 2025

The line this most likely should be applied is here. Although we should double check it isn't meant to be applied elsewhere.

For reference to the specification step, see ParseTimeZoneIdentifier step 4.b.

@nekevss
Copy link
Member Author

nekevss commented Mar 2, 2025

To continue on the above introduction, this will require changes upstream to ixdtf.

Currently, ixdtf only has one UtfOffsetRecord, and this will probably need to be updated to an enum with a MinutePrecisionOffset and FullPrecisionOffset.

The reason being is that a string like 2025-03-02T08:58:00-06:00:00 with sub minute precision cannot be reliably differentiated from 2025-03-02T08:58:00-06:00.

@nekevss nekevss added the C-internal Internal library improvements label Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-internal Internal library improvements
Projects
None yet
Development

No branches or pull requests

1 participant