-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orient-seqs: accept FASTQ data as input #159
Comments
Hi, Thank you very much for opening this issue! I made some progress today. It is working with a single end FASTQ file using the type Best regards, |
Hi @nbokulich |
Hi @VinzentRisch, I think the easiest solution would be to create a separate action specific for handling fastq files, and rename the current action. That is, have two actions, something like I guess my question would be, how to deal with paired-end fastq inputs. Do we just map the forward reads and keep track of which of these is oriented, and then reverse compliment the reverse reads? 🤔 |
vsearch --orient
can accept FASTQ as input (and also output via the--fastqout
option). Ideally,orient-seqs
(which is just thinly wrappingvsearch --orient
) could do the same.This would require modifying the inputs/outputs here: https://github.com/bokulich-lab/RESCRIPt/blob/master/rescript/orient.py#L55
HOWEVER, the main issue I see is that the current inputs and outputs are
DNAFASTAFormat
objects. A FASTQ-formatted input (e.g., coming from some of theSampleData[.*Sequence.*]
types) could not haveDNAFASTAFormat
as a view type. I suppose we need something like aUnion[SingleLanePerSamplePairedEndFastqDirFmt | DNAFASTAFormat | ... ]
as input and output, and aTypeMap
in the plugin registration to accept and output the corresponding types.The text was updated successfully, but these errors were encountered: