Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeSlice function #191

Open
grzkv opened this issue Sep 9, 2019 · 2 comments
Open

Implement timeSlice function #191

grzkv opened this issue Sep 9, 2019 · 2 comments

Comments

@grzkv
Copy link
Member

grzkv commented Sep 9, 2019

There is currently no timeSlice function in this implementation of graphite as defined here. It would be nice to have it.

@paskal
Copy link
Member

paskal commented Sep 12, 2019

I've tried for two days, and either I am missing something very basic, or project data model really doesn't allow proper date parsing within graphite functions (app.defaultTimeZone is unreachable outside of app instance). Whoever had to implement only other function with types.Date parsing (linearRegression) seems to be stunned by the same error: date arguments parsing is not implemented for it at all.
date.DateParamToEpoch seems to be the way to parse types.Date but there is no way to consider app-wise configuration within graphite function call without rewriting bug chunk of the program: python graphite read global settings to parse the time.
I think someone more familiar with the project and with stronger opinion on this matter should implement this in a desired way.

@paskal paskal removed their assignment Sep 12, 2019
@grzkv
Copy link
Member Author

grzkv commented Sep 12, 2019

I agree that the code organization on that part is not perfect. Also, I think the #200 by @KozzyKoder is related.

On top of that, there are currently some problems with timezones in carbonapi the issue is not fully understood IMO, so I did not file it here yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants