Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppenderFactory shouldn't contains logFormat? #28

Open
IRus opened this issue Jan 31, 2017 · 3 comments
Open

AppenderFactory shouldn't contains logFormat? #28

IRus opened this issue Jan 31, 2017 · 3 comments

Comments

@IRus
Copy link
Contributor

IRus commented Jan 31, 2017

Not every appender support logFormat, but currently logFormat defined in appender factory. It's not an issue, but i think we can move logFormat from AppenderFactory.
@andrus
Copy link
Contributor

andrus commented Feb 24, 2017

Is it fair to say then that not every appender supports PatternLayout ? (as PatternLayout at the superclass level is the reason for the logFormat property presence).

@IRus
Copy link
Contributor Author

IRus commented Feb 24, 2017 •
edited
Loading

Yes, sure.

@andrus
Copy link
Contributor

andrus commented Dec 8, 2017

I did something even more evil recently - allowed setting log format at the top level above appenders per #41 . Though this does not preclude refactoring described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrus @IRus