Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in Dommaschk field computation, if R0 not equal 1 #28

Closed
fhindenlang opened this issue Feb 28, 2024 · 1 comment · Fixed by #29
Closed

bug in Dommaschk field computation, if R0 not equal 1 #28

fhindenlang opened this issue Feb 28, 2024 · 1 comment · Fixed by #29

Comments

@fhindenlang
Copy link

https://github.com/boutproject/zoidberg/blob/6df12093c5bfe64576710e1667fd1edaa4c04306/zoidberg/field.py#L591C1-L593C38

Bz is missing the R_0 factor:
Bz = diff(self.P, self.Z) -> Bz = R_0 * diff(self.P, self.Z)
@bshanahan bshanahan mentioned this issue Mar 7, 2024
Merged
@bshanahan
Copy link
Collaborator

Fixed in #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing R_0 factor to Dommaschk fields. (Thanks @fhindenlang) boutproject/zoidberg
2 participants
@bshanahan @fhindenlang