Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify resolution of local plug-in + rules #171

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 24, 2025

Proposed Changes

Related to #81, this PR ensures there is a tested scenario available that shows how rules can be provided locally as part of an application. The solution is straight forward:

  • Develop your rules in a sub-directory of your application, as if it was a bpmnlint plug-in
  • Link (alias) the folder in your main application package, i.e. call it bpmnlint-plugin-local
  • Reference the plug-in as local in wherever places you need
  • 💰

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku nikku added the enhancement New feature or request label Feb 24, 2025
@nikku nikku self-assigned this Feb 24, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 24, 2025
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the setup using stock plugins capabilities works just fine.

@nikku nikku merged commit e23ca12 into main Feb 24, 2025
7 of 9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 24, 2025
@nikku nikku deleted the test-local-rule-resolution branch February 24, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants