Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Replace .isResolved & .isRejected with .state #3438

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments
Open

[CLOSED] Replace .isResolved & .isRejected with .state #3438

core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by TuckerWhitehouse
Monday Apr 29, 2013 at 19:55 GMT
Originally opened as adobe/brackets#3665


This is a step towards the eventually upgrade to jQuery 2.0 (#3123).

Both .isResolved & .isRejected were deprecated in jQuery 1.7 and removed in 1.8 (http://api.jquery.com/deferred.isResolved/).


TuckerWhitehouse included the following code: https://github.com/adobe/brackets/pull/3665/commits

@core-ai-bot
Copy link
Member Author

Comment by TuckerWhitehouse
Monday Apr 29, 2013 at 20:01 GMT


Also, should the wiki/Brackets-Coding-Conventions be updated to advise people to use .state instead of .isResolved or .isRejected?

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Apr 30, 2013 at 21:05 GMT


Reviewing

@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Tuesday Apr 30, 2013 at 21:47 GMT


@TuckerWhitehouse I don't think we necessarily need a note on the wiki to avoid deprecated or soon-to-be-deprecated APIs. Your changes look good and passes tests. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant