Update calls to deprecated methods #313
Conversation
mofeing
changed the title
|
Seems good to me! |
|
Great, then let's merge once all tests pass. |
| @@ -1,3 +1,5 @@ | |||
| using Test | |||
There was a problem hiding this comment.
| using Test |
This is not needed, right?
There was a problem hiding this comment.
this is a recent change i've done: now we include everything needed in the file so that we can run tests on just one file when debugging.
Also, for integration tests now we use SafeTestsets.jl which bundles everything in a module to avoid symbol clashes. In exchange, we need to add the using or import statements on each file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
===========================================
- Coverage 64.76% 51.13% -13.63%
===========================================
Files 36 34 -2
Lines 2401 2370 -31
===========================================
- Hits 1555 1212 -343
- Misses 846 1158 +312 ☔ View full report in Codecov by Sentry. |
Deprecation warnings remain. This PR just fixes calls to deprecated methods on internal code and tests.
@jofrevalles I've renamed$\Lambda$ to a tensor to
contract!onMPSfor contracting theabsorb!because (1) it was conflicting withcontract!(; bond)and the dispatch wasn't working, and (2) I think semantically this is more representative. wdyt?