feat(config)!: controlPlane and worker is now type of NodeConfigs
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow all `NodeConfigs` fields to be applicable on node group (`controlPlane` or `worker` depending on node type) or per node level. The config will be "merged" with everything defined on per node level take precedence, except for `patches` and `extraManifests` to keep the behavior before this commit. Patches and extaManifests defined on both node and node group level will be appended instead. There are 2 new node options to change the behavior of `patches` and `extraManifests` when defined at both the node and node group level. Which are: `overridePatches` and `overrideExtraManifests`. By setting them to `true` will make the `patches` and `extraManifests` defined in node level to override the ones defined in node group level. The config validation is now done after the "merging" is done for each node. So, i.e when you define `schematic` incorrectly in `controlPlane` struct, you might see the validation says you have incorrect `nodes[0].schematic` instead assuming `nodes[0]` is a controlPlane node. BREAKING CHANGE: This commit also remove all the deprecated fields which are: * `talosImageURL` * all `inlinePatch` * all `configPatches` * `nodes[].extensions`
budimanjojo
changed the title
controlPlane and worker is now type of NodeConfigscontrolPlane and worker is now type of NodeConfigs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow all
NodeConfigsfields to be applicable on node group(
controlPlaneorworkerdepending on node type) or per node level.The config will be "merged" with everything defined on per node level
take precedence, except for
patchesandextraManifeststo keep thebehavior before this commit. Patches and extaManifests defined on both
node and node group level will be appended instead.
There are 2 new node options to change the behavior of
patchesandextraManifestswhen defined at both the node and node group level.Which are:
overridePatchesandoverrideExtraManifests. By settingthem to
truewill make thepatchesandextraManifestsdefined innode level to override the ones defined in node group level.
The config validation is now done after the "merging" is done for each
node. So, i.e when you define
schematicincorrectly incontrolPlanestruct, you might see the validation says you have incorrect
nodes[0].schematicinstead assumingnodes[0]is a controlPlane node.BREAKING CHANGE: This commit also remove all the deprecated fields which
are:
talosImageURLinlinePatchconfigPatchesnodes[].extensions