-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spencer's Busbud Coding Challenge #23
Open
spencerdiniz
wants to merge
13
commits into
busbud:master
Choose a base branch
from
spencerdiniz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Blank project. - Added .gitignore
Disabling unnecessary orientations, leaving only portrait.
- Created service and models.
- Calculated distance for each suggestion. - Format distance in KM and Miles. - Update list UI to show distance.
- Support for light/dark modes using sytem colors;
- Disabled zooming in map view.
- Refactored view controllers to user view models
- Adjustments to UI
- Added localization for Portuguese (BR).
- Added unit tests for service. - Added unit tests for view models. - Added unit tests for view controllers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I hope all is well.
This is my submission for the Busbud Coding Challenge for the Senior iOS Engineer Role.
There's room for improvement, optimizations, better abstraction, etc., but I believe this is a good showcase of my proficiency with iOS development.
Home Screen
Location Permission Alert
List View (light)
List View (dark)
Detail View (light)
Detail View (dark)
List View (portuguese localization)
Detail View (portuguese localization)
Busbud Website