Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python setup.py install not working #2

Open
TheHeroBrine422 opened this issue Mar 8, 2015 · 5 comments
Open

python setup.py install not working #2

TheHeroBrine422 opened this issue Mar 8, 2015 · 5 comments

Comments

@TheHeroBrine422
Copy link

full log of error:
Calebs-Mac:ftldat-master caleb$ python setup.py install
Traceback (most recent call last):
File "setup.py", line 8, in
version=get_git_version(),
File "/Users/caleb/Desktop/ftldat-master/get_git_version.py", line 90, in get_git_version
raise ValueError("Cannot find the version number!")
ValueError: Cannot find the version number!

@bwesterb
Copy link
Owner

bwesterb commented Mar 8, 2015

Did you use git or did you download a ZIP from github?

@TheHeroBrine422
Copy link
Author

download ZIP

On Sun, Mar 8, 2015 at 4:21 AM, Bas Westerbaan notifications@github.com
wrote:

Did you use git or did you download a ZIP from github?


Reply to this email directly or view it on GitHub
#2 (comment).

@todlo
Copy link

todlo commented Mar 17, 2015

'describe' wasn't working for me, so i changed it to '--version'... like so:

$ diff get_git_version.py.old get_git_version.py
41c41
<         p = Popen(['git', 'describe', '--abbrev=%d' % abbrev],
---
>         p = Popen(['git', '--version', '--abbrev=%d' % abbrev],

and it worked! :)

@KamodaP
Copy link

KamodaP commented Sep 23, 2016

There's function get_git_version() that reads file "RELEASE-VERSION", which is missing and call

Popen(['git', 'describe', '--abbrev=%d' % abbrev],
                  stdout=PIPE, stderr=PIPE)

assumes you have a git command line installed and, actually, git project cloned locally. I'd recommend to move that into a param file or global variables.
Or update dependencies.
[EDIT]
Well you can't add it to dependencies and have it working since get_git_version is called before dependencies are checked (probably)

@Killbot69
Copy link

This is a terrible installation instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants