-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valmari's Algorithm for Minimizing Partial DFAs #161
Comments
Hey I could give it a shot. Are you guys under any time constraint to get this done? Asking because I will be busy with school. |
@sracha4355 that would be awesome! No time constraint, and feel free to put up a draft PR if you ever want any feedback. |
Any tips on understanding the codebase, I am not an active user. I was just looking for cool projects to contribute to! |
This is actually a fairly good task for someone who is not familiar, as it only involves implementing a single algorithm. The main thing is to take a look at the Basically, the transitions are represented with a nested dictionary, and that is the main structure this algorithm will be operating on. |
@sracha4355 are you still looking into it? Otherwise I could give it a try in the next days |
@EduardoGoulart1 this issue has been open for a while, so if you have the time I'd say go ahead and start working! |
@EduardoGoulart1 Hey, I was planning on tackling this issue once school ends, which is in 2 weeks. But if you would like to work on this, go ahead! If you want to collaborate let me know. |
@sracha4355 Could you please update us here when you start to work on it? I can wait until the turn of the year. But it would be good to have it merged rather soonish |
@EduardoGoulart1 you can go ahead and work on it! |
Don't worry too much about doing overlapping work. I think this algorithm is pretty tricky to implement correctly and might even take a few attempts to get right. |
Originally posted by @eliotwrobson in #126 (comment)
Note this should only be done after #159.
EDIT: We have closed 159 as not being planned, so we can go ahead with this issue if anyone wants to attempt it. Should give substantial performance improvements for minimizing partial DFAs.
The text was updated successfully, but these errors were encountered: