Skip to content

Commit 45420bf

Browse files
authored
fix: remove success logs when rendezvous discovery fails due to no external addrs (#16)
* fix: remove success logs when rendezvous discovery is failed due to no external addrs * chore: bump version
1 parent 83d1f64 commit 45420bf

File tree

7 files changed

+11
-20
lines changed

7 files changed

+11
-20
lines changed

Cargo.lock

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/chat/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "chat-example"
3-
version = "0.4.0"
3+
version = "0.5.0"
44
authors = ["Calimero Limited <info@calimero.network>"]
55
edition = "2021"
66
repository = "https://github.com/calimero-network/boot-node"

examples/chat/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ This examples show cases how to build chat application with DCUtR, mDNS, Relay,
88
## Run
99
Run first chat session in interactive mode with remote peer dial.
1010
```
11-
cargo run -p chat-example -- --mode interactive --port 4002 --secret-key-seed 102 --gossip-topic-names calimero-network/examples/chat/v0.0.2 --boot-nodes /ip4/35.156.78.13/udp/4001/quic-v1/p2p/12D3KooWRnt7EmBwrNALhAXAgM151MdH7Ka9tvYS91ZUqnqwpjVg
11+
cargo run -p chat-example -- --mode interactive --port 4002 --secret-key-seed 102 --gossip-topic-names calimero-network/examples/chat/v0.0.2 --boot-nodes /ip4/18.156.18.6/udp/4001/quic-v1/p2p/12D3KooWMgoF9xzyeKJHtRvrYwdomheRbHPELagWZwTLmXb6bCVC
1212
```
1313

1414
Run second chat session in interactive mode with remote peer dial.
1515
```
16-
cargo run -p chat-example -- --mode interactive --port 4003 --secret-key-seed 103 --gossip-topic-names calimero-network/examples/chat/v0.0.2 --boot-nodes /ip4/35.156.78.13/udp/4001/quic-v1/p2p/12D3KooWRnt7EmBwrNALhAXAgM151MdH7Ka9tvYS91ZUqnqwpjVg
16+
cargo run -p chat-example -- --mode interactive --port 4003 --secret-key-seed 103 --gossip-topic-names calimero-network/examples/chat/v0.0.2 --boot-nodes /ip4/18.156.18.6/udp/4001/quic-v1/p2p/12D3KooWMgoF9xzyeKJHtRvrYwdomheRbHPELagWZwTLmXb6bCVC
1717
```
1818

1919
In any interactive session publish new message manually:

examples/chat/src/network/discovery.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,9 @@ impl EventLoop {
166166
None,
167167
) {
168168
match err {
169-
libp2p::rendezvous::client::RegisterError::NoExternalAddresses => {}
169+
libp2p::rendezvous::client::RegisterError::NoExternalAddresses => {
170+
return Ok(());
171+
}
170172
err => eyre::bail!(err),
171173
}
172174
}

examples/chat/src/network/events.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,11 @@ impl EventLoop {
3131
}
3232
BehaviourEvent::Stream(()) => {}
3333
},
34-
SwarmEvent::NewListenAddr {
35-
listener_id,
36-
address,
37-
} => {
34+
SwarmEvent::NewListenAddr { address, .. } => {
3835
let local_peer_id = *self.swarm.local_peer_id();
3936
if let Err(err) = self
4037
.event_sender
4138
.send(types::NetworkEvent::ListeningOn {
42-
listener_id,
4339
address: address.with(multiaddr::Protocol::P2p(local_peer_id)),
4440
})
4541
.await

examples/chat/src/network/events/gossipsub.rs

+2-6
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,10 @@ impl EventHandler<gossipsub::Event> for EventLoop {
99
debug!("{}: {:?}", "gossipsub".yellow(), event);
1010

1111
match event {
12-
gossipsub::Event::Message {
13-
message_id: id,
14-
message,
15-
..
16-
} => {
12+
gossipsub::Event::Message { message, .. } => {
1713
if let Err(err) = self
1814
.event_sender
19-
.send(types::NetworkEvent::Message { id, message })
15+
.send(types::NetworkEvent::Message { message })
2016
.await
2117
{
2218
error!("Failed to send message event: {:?}", err);

examples/chat/src/network/types.rs

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,18 @@
1-
use libp2p::core::transport;
2-
pub use libp2p::gossipsub::{Message, MessageId, TopicHash};
1+
pub use libp2p::gossipsub::{Message, TopicHash};
32
pub use libp2p::identity::PeerId;
43

54
use super::stream;
65

76
#[derive(Debug)]
87
pub enum NetworkEvent {
98
ListeningOn {
10-
listener_id: transport::ListenerId,
119
address: libp2p::Multiaddr,
1210
},
1311
Subscribed {
1412
peer_id: PeerId,
1513
topic: TopicHash,
1614
},
1715
Message {
18-
id: MessageId,
1916
message: Message,
2017
},
2118
StreamOpened {

0 commit comments

Comments
 (0)