-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combining EDS API with EAM API #288
Comments
Hi @maheshc01, this is one of the issues that we discussed on the last meeting, as you can see the idea is to reuse the existing yaml(API), and add the funcionality of EDS to EAM. Do you think is possible?? |
Summarizing the discussion we have on this topic during the weekly call: This would ensure that we are inline with TSC recommendation to not make API very big leading to partial implementations. This way operators can choose to implementation both application orchestration/mgmt APIs and Application endpoint discovery APIs or just 1 of them but have a complete implementation of a given yaml. Action based on the discussion: |
Unfortunately I think the GET /edge-cloud-zones API still needs to be in EAM, because EAM APIs (like POST /appinstances) use the edge-cloud-zone-ID in their requests. Without the GET /edge-cloud-zones API, it's unclear how the user would figure out what the possible edge-cloud-zone-IDs are for the POST /appinstances requests. |
Hi @gainsley , here is an similar example where id/name from 1 api is used as input in another API. Point i am trying to make is, even though edge-cloud-zone-ID is required in EAM as an input param, its not necessary that the GET /edge-cloud-zone API is in the same yaml. there can be in 2 different yamls. and its up to the developers to decide if they want to use the GET /edge-cloud-zone to get the cloud-zone-ID or they use other means to decide on it. |
I see, this is a tricky issue. Some comments:
|
Hi @gainsley please find my response to the points you raise below:
|
Hi @maheshc01 thanks for you reply, just trying to understand the intent better here. Regarding the other comments, I need to understand better how things are intended to work. I'll ask some questions on the PR directly. Thanks. |
thanks for clarifying on the QosProfile multiple definition. I could see that as a generic and valid concern. We do the same for the definition of Device across most of the CAMARA APIs. I am not sure if linting rules already checks for consistentcy but if not it would be great to have it incorporated. Tagging @JoseMConde @Kevsy and @hdamker as this i a good discussion with lot of details. Please chime in if there is anything you would like to add. |
Thanks @maheshc01 , I am preparing some slides to disccus about this tomorrow in our meeting, this is a very interesting discussion and we will have to get an agreement. My view is more closely to the Jon's comments but we can discuss deeply in the meeting. |
In this case it is only QosProfileName (and not the QosProfile schema) which is duplicated across the (three) API definitions which are using this identifier. Luckily the format of such identifier should anyway not be changed by all means. But I agree that the copy&past approach is not perfect, but we decided in this and also other cases to use the approach for now, as otherwise - when using references - we wouldn't have yet the appropriate tooling, starting with the presentation of the API within swagger editor. One approach could be to have a source file with references and a generated "bundled" API definition which has all references resolved ... but that would require the introduction of scripting and GitHub actions. If there are volunteers we can start such activity, most probably in Commonalities. |
Problem description
1. GET /mecplatforms ESD API vs GET /edge-cloud-zones EAM API:
GET /mecplatforms ESD API: Returns a list of optimal MEC Platforms where you can register your deployed application. You can choose to search without passing any of the inputs parameters or combination of Application Profile, Region, Subscriber or UEIdentity.
This method is very interesting and covers part of intent 20, which is outside the scope of the MVP proposal, but was considered for the improvement phase.
GET /edge-cloud-zones EAM API: Returns a list of Edge Cloud Zones and their status, ordering the results by location (region) and filtering by status (active/inactive/unknown)
2. Application Profiles capabilites
This Operation allows to: Create and manage profiles that describe the application requirements of your MEC applications, such as the required connection bandwidth and maximum latency.
Expected behavior
Improve Edge Cloud Zones discovery capability combining the functionalities, allowing developers to discover them based on Application Profile, Region, Subscriber, UEIdentity and Status.
There is a conflict with the Application Profiles capability of the EDS API and the requiredResources object of the EAM API, we need to combine them into one API.
Alternative solution
Additional context
The text was updated successfully, but these errors were encountered: