Skip to content

Commit

Permalink
chore(linting): read documentation url from rule metadata
Browse files Browse the repository at this point in the history
Closes #4491
  • Loading branch information
kmannuru authored and nikku committed Feb 20, 2025
1 parent 4f72aef commit 05d6802
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ___Note:__ Yet to be released changes appear here._
### General

* `FEAT`: support Camunda 8.8
* `FEAT`: recognize documentation URLs provided via lint rules ([#4491](https://github.com/camunda/camunda-modeler/issues/4491))
* `DEPS`: update to `@camunda/improved-canvas@1.7.6`
* `DEPS`: update to `@camunda/linting@3.32.1`

Expand Down
4 changes: 2 additions & 2 deletions client/src/app/panel/tabs/linting/LintingTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ function LintingTabItem(props) {

const {
category,
documentation = {},
meta,
message,
rule
} = report;
Expand All @@ -109,7 +109,7 @@ function LintingTabItem(props) {
</div>;
}

const { url: documentationUrl = null } = documentation;
const documentationUrl = meta?.documentation?.url;
const reportName = getReportName(report);

return <div
Expand Down
6 changes: 4 additions & 2 deletions client/src/app/panel/tabs/linting/__tests__/LintingTabSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,10 @@ describe('<LintingTab>', function() {
name: 'Foo',
message: 'Foo message',
rule: 'foo-rule',
documentation: {
url: 'https://foo.bar'
meta: {
documentation: {
url: 'https://foo.bar'
}
}
}
]
Expand Down

0 comments on commit 05d6802

Please sign in to comment.