-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make text in tooltip selectable #4841
Conversation
The selection works, but it is impossible to do if you open the tooltip via click. This is probably related to how we hide the tooltip: https://github.com/bpmn-io/properties-panel/blob/main/src/components/entries/Tooltip.js#L93C23-L93C39 Screen.Recording.2025-02-20.at.13.39.45.mov |
CSS is good but it solves the issue only partially. The rest needs to be fixed upstream though. |
@jarekdanielak for the properties panel part, this may be useful: https://developer.mozilla.org/en-US/docs/Web/API/Selection/containsNode |
Let me fix the properties panel part and reopen this when it's ready. |
We could also merge this, and open a separate issue of "Tooltip closes unexpectedly when trying to select" (closing #4834). |
Let's merge this and look into bpmn-io/properties-panel#399 for more improvements on the tooltips. |
Closes #4834
Proposed Changes
Make text inside of a tooltip selectable.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}