Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: header spacing and forms layout MAASENG-2892 #5361

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix: header spacing and forms layout MAASENG-2892 #5361

merged 3 commits into from
Mar 20, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 20, 2024 •
edited
Loading

Done

  • fix: layout header
    • refactor SectionHeader to use MainToolbar internally
  • fix: inline forms layout
    • fixes node name edit forms layout when displayed in the title

QA steps

  • Go to all of the main pages and verify that there are no unexpected changes in the header section
  • Go to machine details page
  • Click on machine name
  • Verify the form is displayed inline and not using ContentSection wrapper

Fixes

Fixes: https://warthogs.atlassian.net/browse/MAASENG-2892

Screenshots

Before

Google Chrome screenshot 001699@2x

After

Google Chrome screenshot 001697@2x

Before

Google Chrome screenshot 001693@2x

After

Google Chrome screenshot 001691@2x

Before

Google Chrome screenshot 001683@2x

After

Google Chrome screenshot 001689@2x

Before

Google Chrome screenshot 001685@2x

After

Google Chrome screenshot 001687@2x

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5361.demos.haus

@petermakowski petermakowski changed the title fix: layout header WIP fix: layout header spacing MAASENG-2892 WIP Mar 20, 2024
@petermakowski petermakowski changed the title fix: layout header spacing MAASENG-2892 WIP fix: header spacing and forms layout MAASENG-2892 WIP Mar 20, 2024
@petermakowski
fix: inline forms layout
0cf0ad4 
- fixes node name edit forms layout when displayed in the title
@petermakowski petermakowski changed the title fix: header spacing and forms layout MAASENG-2892 WIP fix: header spacing and forms layout MAASENG-2892 Mar 20, 2024
@petermakowski petermakowski marked this pull request as ready for review March 20, 2024 14:08
@petermakowski petermakowski merged commit 827c454 into canonical:main Mar 20, 2024
7 checks passed
@petermakowski petermakowski deleted the fix-layout-header branch March 20, 2024 15:32
@ndv99 ndv99 mentioned this pull request Apr 30, 2024
Closed
@petermakowski petermakowski restored the fix-layout-header branch May 9, 2024 10:21
@petermakowski petermakowski deleted the fix-layout-header branch May 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @Jay-Topher