Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: factory imports #5362

Merged
merged 1 commit into from
Mar 20, 2024
Merged

refactor: factory imports #5362

merged 1 commit into from
Mar 20, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 20, 2024 •
edited
Loading

Done

  • refactor: simplify factory imports, reducing the number of lines by 3,951
    +11,198 −15,149

Note

  • This work has been automated using a python script and a set of regular expressions.
  • Changes isolated to test files to ensure the integrity of the production codebase

Screenshots

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5362.demos.haus

@petermakowski petermakowski force-pushed the refactor-factory-imports branch from 074841e to 2ee5ba5 Compare March 20, 2024 15:34
@petermakowski petermakowski force-pushed the refactor-factory-imports branch from 2ee5ba5 to bfc48e0 Compare March 20, 2024 15:37
@petermakowski petermakowski changed the title refactor: factory imports WIP refactor: factory imports Mar 20, 2024
@petermakowski petermakowski marked this pull request as ready for review March 20, 2024 15:49
ndv99
ndv99 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a good change, +1 from me!

@petermakowski petermakowski merged commit 7a3a174 into canonical:main Mar 20, 2024
8 checks passed
@petermakowski petermakowski deleted the refactor-factory-imports branch May 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Awaiting requested review from Jay-Topher

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petermakowski @webteam-app @ndv99