Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move file system forms to side panel #5365

Conversation

Jay-Topher
Copy link
Contributor

@Jay-Topher Jay-Topher commented Mar 21, 2024

Done

Moved File system table forms to side panel

  • Delete Filesystem
  • Unmount Filesystem
  • Delete special filesystem

QA steps

  • Visit the storage tab of a ready state machine
  • In the file systems table, click the action dropdown for a file system
  • Ensure all actions open in a side panel
  • Click the Add special filesystem button to add a special file sysem
  • Ensure that the actions for that file system also open up in a side panel
  • Ensure that the side panel forms work as expected

Fixes

Fixes: MAASENG-2874

Screenshots

Before

image

After

image

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5365.demos.haus

@ndv99
Copy link
Contributor

ndv99 commented Mar 21, 2024

This isn't a problem with your PR, but one that I think was introduced recently on another PR - the padding at the top of the side panels feels way too small, and is inconsistent with the rest of the app:
image

@petermakowski do you have any ideas?

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jay-Topher
Copy link
Contributor Author

This isn't a problem with your PR, but one that I think was introduced recently on another PR - the padding at the top of the side panels feels way too small, and is inconsistent with the rest of the app: image

@petermakowski do you have any ideas?

True, it was different before the rebase, it should be an easy enough fix

@Jay-Topher
Copy link
Contributor Author

@ndv99 it happened when the top padding was removed
image

@Jay-Topher Jay-Topher merged commit 0bf1d6f into canonical:main Mar 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants