Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align side panel content section header #5367

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: align side panel content section header #5367

merged 1 commit into from
Mar 21, 2024

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Mar 21, 2024 •
edited
Loading

Done

  • fix: side panel content section

QA steps

  • Verify that the header of the side panel is aligned with the header of the main section

Fixes

Fixes:

Screenshots

Before

Google Chrome screenshot 001717@2x

After

Google Chrome screenshot 001715@2x

Notes

@webteam-app
Copy link

Demo starting at https://maas-ui-5367.demos.haus

@petermakowski petermakowski changed the title fix: side panel content section WIP fix: align side panel content section header WIP Mar 21, 2024
@petermakowski petermakowski changed the title fix: align side panel content section header WIP fix: align side panel content section header Mar 21, 2024
@petermakowski petermakowski marked this pull request as ready for review March 21, 2024 15:35
ndv99
ndv99 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for fixing this

@petermakowski petermakowski merged commit 73e3ad9 into canonical:main Mar 21, 2024
10 checks passed
@petermakowski petermakowski deleted the fix-side-panel-content-section branch March 21, 2024 15:51
@petermakowski petermakowski restored the fix-side-panel-content-section branch May 9, 2024 10:21
@petermakowski petermakowski deleted the fix-side-panel-content-section branch May 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petermakowski @webteam-app @ndv99 @Jay-Topher