Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(machines): Allow deselection of machines in a selected group MAASENG-3720 #5537

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Sep 25, 2024

Done

  • Selecting a group of machines:
    • adds the system IDs of (visible) machines in that group to the selection state, instead of the group key
    • does NOT select every machine in that group, only the ones on screen
  • Machines in a selected group can now be unselected

QA steps

I recommend doing this using a MAAS instance with a good amount of sample data.

  • Go to machine list
  • Select a group of machines
  • Ensure the checkboxes are all checked in that group, but not disabled
  • Ensure you can unselect machines
  • Select a group of machines that's bigger than what can be shown on one page ("Ready" is good in sampledata)
  • Ensure only the machines on that page are selected

Fixes

Resolves MAASENG-3720
Resolves LP:2056157

Screenshots

Before

image

After

image

@webteam-app
Copy link

@ndv99 ndv99 marked this pull request as ready for review September 25, 2024 15:49
Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA:
In a partially selected group, the select button of the group stops working
Screenshot from 2024-09-26 16-56-43

Code:
I think you forgot updating the tests, see inline comment.

Copy link
Collaborator

@tmerten tmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for adding that partial select test.

@ndv99 ndv99 merged commit b97fc5e into canonical:main Sep 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants