Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(machines): Add kernel crash dump indicator to details page MAASENG-3760 #5540

Conversation

ndv99
Copy link
Contributor

@ndv99 ndv99 commented Oct 1, 2024

Done

  • Added kernel crash dump state indicator to machine details

QA steps

  • Add the following to your .env.local:
VITE_APP_KERNEL_CRASH_DUMP_ENABLED = true
  • Checkout this branch locally and spin up the dev server
  • Go to a machine's details page
  • Ensure you can see the status of kernel crash dump (enabled)
  • Go to src/app/base/components/node/OverviewCard/DetailsCard/DetailsCard.tsx in your code editor
  • Set kernelCrashDumpEnabled on L63 to false
  • Ensure the indicator on the details page is disabled

Fixes

Fixes MAASENG-3760

Screenshots

image

@webteam-app
Copy link

@ndv99 ndv99 marked this pull request as ready for review October 1, 2024 14:38
@ndv99 ndv99 changed the title feat(machines): Add kernel crash dump indicator to details page MAANG-3760 feat(machines): Add kernel crash dump indicator to details page MAASENG-3760 Oct 2, 2024
@ndv99 ndv99 merged commit 4a29667 into canonical:main Oct 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants