-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(images): Implement design for image table header MAASENG-4359 #5595
feat(images): Implement design for image table header MAASENG-4359 #5595
Conversation
Regarding the first point of the notes:
Regarding the second point of the notes:
|
Moving the "Automatically sync images" setting into the "Change source" form, any Formik form for that matter, is proving to be problematic because the dispatch used to update the setting interferes with the form's internal rendering (Cannot update a component while rendering a different component). It is definitely something that needs attention, but maybe moving the "Change source" to its own settings page requires its own ticket. MAASENG-4367 |
Were the buttons displayed when there was no "Stop image import"? Because if they weren't, this is due to Redux store and web socket having a delay between one another. Picking a "longer" download should both disable the buttons and display the "Stop image import" link button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is mostly there, could you just add a couple of tests for things like disabling/enabling the "Delete" button when images are selected? TY
Ahhh yes, good point. Selected some bigger images and the link button appeared. In that case, QA +1 |
…elect upstream images, stop image import and delete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Done
MainToolbar.Controls
getRowId
returning the record id instead of table row indexQA steps
Fixes
Resolves:
MAASENG-4359
Screenshots
Notes