From 8317c80d54c918eab363b778d8a8208605534c60 Mon Sep 17 00:00:00 2001
From: Sam Cao <sjtucaocao@gmail.com>
Date: Tue, 9 Apr 2024 12:19:36 +0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9E=20fix:=20Fix=20improper=20memory?=
 =?UTF-8?q?=20span=20in=20Node.js=20mode?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 cpp/jni/javet_jni_module.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/cpp/jni/javet_jni_module.cpp b/cpp/jni/javet_jni_module.cpp
index 062ceeffc..79fcfe998 100644
--- a/cpp/jni/javet_jni_module.cpp
+++ b/cpp/jni/javet_jni_module.cpp
@@ -77,11 +77,17 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_moduleCreate
                     }
                 }
             }
+#ifndef ENABLE_NODE
             v8::MemorySpan<const V8LocalString> exportNamesMemorySpan(exportNames.begin(), exportNames.end());
+#endif
             auto v8LocalModule = v8::Module::CreateSyntheticModule(
                 v8Context->GetIsolate(),
                 Javet::Converter::ToV8String(jniEnv, v8Context, mModuleName),
+#ifdef ENABLE_NODE
+                exportNames,
+#else
                 exportNamesMemorySpan,
+#endif
                 Javet::Callback::JavetSyntheticModuleEvaluationStepsCallback);
             std::string stringKey("module:{}" + std::to_string(v8LocalModule->GetIdentityHash()));
             auto v8LocalStringKey = Javet::Converter::ToV8String(v8Context, stringKey.c_str());