You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @caseycesari, i love your library and all the work that has been done here !
But it is missing type definitions and the fact that @types/geojson isn't providing it is really confusing at the start of using the library.
I saw that someone did a typescript version on a fork of the library here but overall it's just a duplication of the current js with addition of bad types on top of it.
I added a custom type file on my side that types the lib with modern and precise typescript:
It uses @types/geojson and extend it to provide the types of your library.
It works perfectly, i have tested it with all the examples provided in the readme.
It won't change anything for the js part i would just add a geojson.d.ts file and declare it in the package.json.
I just need your feedback on the typescript if you have one and your approval for the pull request.
The text was updated successfully, but these errors were encountered:
Hi @caseycesari, i love your library and all the work that has been done here !
But it is missing type definitions and the fact that
@types/geojson
isn't providing it is really confusing at the start of using the library.I saw that someone did a typescript version on a fork of the library here but overall it's just a duplication of the current js with addition of bad types on top of it.
I added a custom type file on my side that types the lib with modern and precise typescript:
It uses
@types/geojson
and extend it to provide the types of your library.It works perfectly, i have tested it with all the examples provided in the readme.
It won't change anything for the js part i would just add a
geojson.d.ts
file and declare it in the package.json.I just need your feedback on the typescript if you have one and your approval for the pull request.
The text was updated successfully, but these errors were encountered: