Skip to content

Commit

Permalink
issues/245 - Tidy up for code review
Browse files Browse the repository at this point in the history
  • Loading branch information
meywood committed Feb 13, 2024
1 parent 888f371 commit 2017a2e
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions src/main/java/com/casper/sdk/service/CasperService.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
*/
public interface CasperService {


/**
* Builds a CasperService for the node url.
*
* @param url the peer url to connect to
* @param url the peer url to connect to
* @param additionalHeaders additional headers to be added to the request
* @return A Dynamic Proxy to CasperService
* @throws MalformedURLException is thrown if ip/port are not compliant
Expand All @@ -56,16 +55,15 @@ static CasperService usingPeer(URL url, final Map<String, String> additionalHead
if (StringUtils.isEmpty(url.getPath())) {
url = new URL(url.getProtocol(), url.getHost(), url.getPort(), "/rpc");
}
final CasperObjectMapper objectMapper = new CasperObjectMapper();
final Map<String, String> newHeaders = new HashMap<>();
newHeaders.put("Content-Type", "application/json");

final Map<String, String> headers = new HashMap<>();
headers.put("Content-Type", "application/json");
if (additionalHeaders != null) {
newHeaders.putAll(additionalHeaders);
headers.putAll(additionalHeaders);
}
final JsonRpcHttpClient client = new JsonRpcHttpClient(objectMapper, url, newHeaders);

final ExceptionResolver exceptionResolver = new CasperClientExceptionResolver();
client.setExceptionResolver(exceptionResolver);
final JsonRpcHttpClient client = new JsonRpcHttpClient(new CasperObjectMapper(), url, headers);
client.setExceptionResolver(new CasperClientExceptionResolver());

return ProxyUtil.createClientProxy(CasperService.class.getClassLoader(), CasperService.class, client);
}
Expand Down

0 comments on commit 2017a2e

Please sign in to comment.