3.11 and 3.4 branches use unsupported arrow syntax

[peta3000]

Dear Devs

After updating the mod_facetoface plugin to latest upstream-commit (e9f5a14) on MOODLE_400_STABLE branch, when re-deploying the installation-process exits with the following error messages:

-->System
Default exception handler: Exception - syntax error, unexpected '$s' (T_VARIABLE), expecting ')' Debug: 
Error code: generalexceptionmessage
* line 1100 of /mod/facetoface/lib.php: ParseError thrown
* line 69 of /backup/moodle2/restore_plan_builder.class.php: call to plugin_supports()
* line 85 of /backup/util/includes/restore_includes.php: call to require_once()
* line 18 of /backup/util/helper/copy_helper.class.php: call to require_once()
* line 64 of /backup/util/includes/backup_includes.php: call to require_once()
* line 28 of /lib/classes/task/backup_cleanup_task.php: call to require_once()
* line 136 of /lib/classes/component.php: call to include_once()
* line ? of unknownfile: call to core_component::classloader()
* line ? of unknownfile: call to spl_autoload_call()
* line 347 of /lib/classes/task/manager.php: call to class_exists()
* line 70 of /lib/classes/task/manager.php: call to core\task\manager::scheduled_task_from_record()
* line 90 of /lib/classes/task/manager.php: call to core\task\manager::load_default_scheduled_tasks_for_component()
* line 1821 of /lib/upgradelib.php: call to core\task\manager::reset_scheduled_tasks_for_component()
* line 484 of /lib/installlib.php: call to install_core()
* line 186 of /admin/cli/install_database.php: call to install_cli_database()
!!! Exception - syntax error, unexpected '$s' (T_VARIABLE), expecting ')' !!!
!! 
Error code: generalexceptionmessage !!
!! Stack trace: * line 1100 of /mod/facetoface/lib.php: ParseError thrown
* line 69 of /backup/moodle2/restore_plan_builder.class.php: call to plugin_supports()
* line 85 of /backup/util/includes/restore_includes.php: call to require_once()
* line 18 of /backup/util/helper/copy_helper.class.php: call to require_once()
* line 64 of /backup/util/includes/backup_includes.php: call to require_once()
* line 28 of /lib/classes/task/backup_cleanup_task.php: call to require_once()
* line 136 of /lib/classes/component.php: call to include_once()
* line ? of unknownfile: call to core_component::classloader()
* line ? of unknownfile: call to spl_autoload_call()
* line 347 of /lib/classes/task/manager.php: call to class_exists()
* line 70 of /lib/classes/task/manager.php: call to core\task\manager::scheduled_task_from_record()
* line 90 of /lib/classes/task/manager.php: call to core\task\manager::load_default_scheduled_tasks_for_component()
* line 1821 of /lib/upgradelib.php: call to core\task\manager::reset_scheduled_tasks_for_component()
* line 484 of /lib/installlib.php: call to install_core()
* line 186 of /admin/cli/install_database.php: call to install_cli_database()
 !!

[danmarsden]

@cameron1729 this looks like a regression caused by #104 - are you able to please take a look?

@dmitriim FYI ^

[cameron1729]

Hi @peta3000 - what version of PHP are you using?

[peta3000]

Hi @cameron1729 thanks for the quick reply:
It's PHP 7.3.31 from a debian package:
https://packages.debian.org/buster/php7.3

cheers
p

[cameron1729]

Hi @peta3000 - that version of PHP is not supported in Moodle 4.0 (the branch you are using) - for a list of supported PHP versions please see here: https://moodledev.io/general/development/policies/php

However there is still a problem here in that the MOODLE_311_STABLE and MOODLE_34_STABLE branches are using the same arrow function syntax, and those branches should support PHP 7.0-7.3

I'll update the title of this issue to reflect that, thanks!

[peta3000]

Hi @cameron1729
Thanks for your reply!
I really appreciate it!
I'm going to update the instance to 7.4, run a trial and get back with a short update!
Cheers

[peta3000]

Hi @cameron1729
Short update:
Deployment with PHP 4.7 worked fine.
Regarding my initial request this ticket can be regarded as closed :).
Thanks a lot for your quick and professional support!

Cheers
p