Merge pull request #55 from cdyk/32bit-offset

cdyk · web-flow · commit 02f6fa8f9443 · 2022-12-21T12:26:37.000+01:00
Only compare lower 32 bits of offset since expected offset is a 32 bi…
diff --git a/src/ParserRVM.cpp b/src/ParserRVM.cpp
@@ -99,7 +99,7 @@ namespace {
   bool verifyOffset(Context* ctx, const char* chunk_type, const char* base_ptr, const char* curr_ptr, uint32_t expected_next_chunk_offset)
   {
     size_t current_offset = curr_ptr - base_ptr;
-    if (current_offset == expected_next_chunk_offset) {
+    if (static_cast<uint32_t>(current_offset) == expected_next_chunk_offset) {
       return true;
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ namespace {`
`99`	`99`	`bool verifyOffset(Context* ctx, const char* chunk_type, const char* base_ptr, const char* curr_ptr, uint32_t expected_next_chunk_offset)`
`100`	`100`	`{`
`101`	`101`	`size_t current_offset = curr_ptr - base_ptr;`
`102`		`- if (current_offset == expected_next_chunk_offset) {`
	`102`	`+ if (static_cast<uint32_t>(current_offset) == expected_next_chunk_offset) {`
`103`	`103`	`return true;`
`104`	`104`	`}`
`105`	`105`	`else {`