Skip to content

Commit b98cfbe

Browse files
committed
Fix bug and add more tests
1 parent 19dcc80 commit b98cfbe

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ namespace CefSharp
180180
{
181181
auto origin = _jsBindingApiAllowOrigins->GetString(i);
182182

183-
if (origin.compare(frameUrlOrigin))
183+
if (origin.compare(frameUrlOrigin) == 0)
184184
{
185185
createObjects = true;
186186

CefSharp.Test/JavascriptBinding/JavascriptBindingTests.cs

+5-3
Original file line numberDiff line numberDiff line change
@@ -157,14 +157,16 @@ public async Task ShouldDisableJsBindingApiForOrigin()
157157
}
158158
}
159159

160-
[Fact]
161-
public async Task ShouldEnableJsBindingApiForOrigin()
160+
[Theory]
161+
[InlineData(CefExample.ExampleDomain)]
162+
[InlineData("someorigin", CefExample.ExampleDomain)]
163+
public async Task ShouldEnableJsBindingApiForOrigin(params string[] origins)
162164
{
163165
using (var browser = new ChromiumWebBrowser(CefExample.BindingApiCustomObjectNameTestUrl, automaticallyCreateBrowser: false))
164166
{
165167
var settings = browser.JavascriptObjectRepository.Settings;
166168
settings.JavascriptBindingApiEnabled = true;
167-
settings.JavascriptBindingApiAllowOrigins = new string[] { CefExample.ExampleDomain };
169+
settings.JavascriptBindingApiAllowOrigins = origins;
168170

169171
//To modify the settings we need to defer browser creation slightly
170172
browser.CreateBrowser();

0 commit comments

Comments
 (0)