Skip to content

Commit 054ab10

Browse files
authored
Move non-field-specific errors to top of edit and create forms. (aminalaee#707)
1 parent 85dd4f1 commit 054ab10

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

sqladmin/templates/create.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ <h3 class="card-title">New {{ model_view.name }}</h3>
88
<div class="card-body border-bottom py-3">
99
<form action="{{ url_for('admin:create', identity=model_view.identity) }}" method="POST"
1010
enctype="multipart/form-data">
11+
<div class="row">
12+
{% if error %}
13+
<div class="alert alert-danger" role="alert">{{ error }}</div>
14+
{% endif %}
15+
</div>
1116
<fieldset class="form-fieldset">
1217
{% for field in form %}
1318
<div class="mb-3 form-group row">
@@ -26,9 +31,6 @@ <h3 class="card-title">New {{ model_view.name }}</h3>
2631
{% endfor %}
2732
</fieldset>
2833
<div class="row">
29-
{% if error %}
30-
<div class="alert alert-danger" role="alert">{{ error }}</div>
31-
{% endif %}
3234
<div class="col-md-2">
3335
<a href="{{ url_for('admin:list', identity=model_view.identity) }}" class="btn">
3436
Cancel

sqladmin/templates/edit.html

+5-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ <h3 class="card-title">Edit {{ model_view.name }}</h3>
88
<div class="card-body border-bottom py-3">
99
<form action="{{ model_view._build_url_for('admin:edit', request, obj) }}" method="POST"
1010
enctype="multipart/form-data">
11+
<div class="row">
12+
{% if error %}
13+
<div class="alert alert-danger" role="alert">{{ error }}</div>
14+
{% endif %}
15+
</div>
1116
<fieldset class="form-fieldset">
1217
{% for field in form %}
1318
<div class="mb-3 form-group row">
@@ -26,9 +31,6 @@ <h3 class="card-title">Edit {{ model_view.name }}</h3>
2631
{% endfor %}
2732
</fieldset>
2833
<div class="row">
29-
{% if error %}
30-
<div class="alert alert-danger" role="alert">{{ error }}</div>
31-
{% endif %}
3234
<div class="col-md-2">
3335
<a href="{{ url_for('admin:list', identity=model_view.identity) }}" class="btn">
3436
Cancel

0 commit comments

Comments
 (0)