Cannot detect absence of network

[chadxz]

Originally reported in #101

If you start to connect to a remote server in the absence of a network, errors can also not be caught without debug. They simply have nowhere to catch as there is no websocket object. This object appears only when there is a connection, if I understand correctly.

[chadxz]

@GolDiV I will restate the problem to make sure I understand what you are saying.

When creating an instance of the websocket client in the absence of a network connection, you're unable to intercept the error.

I've got a test for this scenario. https://github.com/chadxz/awry/blob/master/test/events/ReconnectingWebsocket.spec.js#L66-L96

It simulates an error prior to a connection by making the validation fail when connecting to the server.

It sounds like that test isn't an accurate representation of your issue though.

Can you verify that I understand your problem correctly?

[GolDiV]

I experimented a bit and came to the following conclusion. In your test input parameter (verifyClient) set correctly, but it seemed to me you are testing is not quite the same event. I will try to show it an example:

const events = awry.Events.connect({
    app: 'app',
    url: host,
    username: user,
    password: password
  })
  events.on('open', () => {
    console.log('Connection ON')
    pingpong(events._ws)
  })
  events.on('disconnected', (err) => {
    console.log('Connection OFF. Error: ')
    console.log(err)
  })
  events.on('reconnected', () => {
    console.log('Reconnected')
    pingpong(events._ws)
  })
  events.on('close', () => console.log('Connection closed'))
  events.on('error', () => console.log('Connection error'))

  events._ws.on('error', (err) => console.log(err))

  function pingpong (ws) {
    setInterval(() => ws.ping(() => {}), 3000)
  }

I have a remote server asterisk so to break the connection I pull out the network cable.
Case one:
I disconnect my network cable and start script.
The event events._ws.on('error', ...) is triggered and its triggered only once. But in debug mode i see some attempts to reconnect.
Then I connect network cable and the event events.on('open',...) is triggered.
Case two
I connected with server normally. Event events.on('open',...) is triggered. Then i disconnect cable.
By reason of function ping, the client learns about the disconnection, and event events.on('disconnected',...) is triggered. After turn on network event events.on('reconnected',...) is triggered.
And in both cases event events.on('error',...) never works.

[chadxz]

For each case can you describe what you expected to be the behavior?

[GolDiV]

Ideally, I want to listen to errors by one listener such as event.on ('error',...) and receive all connection error events from it.

[GolDiV]

Hi Chad! I think I found the solution. Into file ReconnectingWebSocket.js (master) I add into row 109 next code:

this.emit("error", { err, reconnect: this._reconnect, numRetries })

After that listener events.on('error',...) catches all connection errors, including failed attempts to reconnect