You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now all requests are made through request-promise-native using default configuration. A consumer of this library may want to customize its behavior for things like disabling rejectUnauthorized, enabling resolveWithFullResponse, disabling simple, etc.
May also want to re-visit the decisions made around the defaults for these options.
The text was updated successfully, but these errors were encountered:
talked to Sam about this last week. Would be really easy to add a requestOptions to each api constructor, and Object.assign({}, requestOptions, { ... }) to merge the passed options with the options set explicitly in the constructor.
The above branch is no longer relevant because we've migrated from request to axios. The concerns in this ticket are still relevant even when using axios, though. Leaving this open for now.
Right now all requests are made through request-promise-native using default configuration. A consumer of this library may want to customize its behavior for things like disabling
rejectUnauthorized
, enablingresolveWithFullResponse
, disablingsimple
, etc.May also want to re-visit the decisions made around the defaults for these options.
The text was updated successfully, but these errors were encountered: