Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options to request-promise-native; Revisit defaults #38

Open
chadxz opened this issue Oct 18, 2017 · 4 comments
Open

Allow passing options to request-promise-native; Revisit defaults #38

chadxz opened this issue Oct 18, 2017 · 4 comments

Comments

@chadxz
Copy link
Owner

chadxz commented Oct 18, 2017

Right now all requests are made through request-promise-native using default configuration. A consumer of this library may want to customize its behavior for things like disabling rejectUnauthorized, enabling resolveWithFullResponse, disabling simple, etc.

May also want to re-visit the decisions made around the defaults for these options.

@chadxz
Copy link
Owner Author

chadxz commented Nov 22, 2017

Another consideration is anything special sent to asterisk via headers. Is there anything like that ever?

@chadxz
Copy link
Owner Author

chadxz commented Apr 15, 2018

talked to Sam about this last week. Would be really easy to add a requestOptions to each api constructor, and Object.assign({}, requestOptions, { ... }) to merge the passed options with the options set explicitly in the constructor.

@chadxz chadxz self-assigned this May 9, 2018
@chadxz
Copy link
Owner Author

chadxz commented May 9, 2018

working on this in https://github.com/chadxz/awry/tree/38-request-options

@chadxz
Copy link
Owner Author

chadxz commented May 10, 2020

The above branch is no longer relevant because we've migrated from request to axios. The concerns in this ticket are still relevant even when using axios, though. Leaving this open for now.

@chadxz chadxz removed their assignment May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant