[Bug]: mason publish missing link to create a PR

[jeremiah-corrado]

The mason publish command should provide the user with a github URL to create a pull request against the mason package registry. See the "publish steps" section in these docs: https://chapel-lang.org/docs/tools/mason/guide/submitting.html

In testing this, I'm seeing that no URL is provided, and the user gets the following output:

--------------------------------------------------------------------
Go to the above link to open up a Pull Request to the mason-registry

It is still possible to create the pull request manually from the user's fork of the mason registry.

[lucaferranti]

I can confirm this happened to me when doing chapel-lang/mason-registry#74

[lucaferranti]

Isn't the link always

https://github.com/chapel-lang/mason-registry

?

Looking at the lines in MasonPublish

    if !isLocal {
      gitC(safeDir + "/mason-registry", "git add .");
      commitSubProcess(safeDir + '/mason-registry', command);
      gitC(safeDir + "/mason-registry", 'git push --set-upstream origin ' + name, true);
      rmTree(safeDir + '/');
      writeln('--------------------------------------------------------------------');
      writeln('Go to the above link to open up a Pull Request to the mason-registry');
     }

and thinking about what git steps are called under the hood, I am not sure which one (if any) would print the link to the upstream registry repository. Even if there is one, I would guess also the link to the fork gets printed somewhere and moreover hunting the link from what git prints might be a bit confusing.

All in all, I think the quickiest (and not even dirty) fix would be to replace the second writeln with something like

writeln('Go to https://github.com/chapel-lang/mason-registry  to open up a Pull Request to the mason-registry');

any downside to this?

[jeremiah-corrado]

Isn't the link always

I think linking to the registry repo would be a good solution; however it might also be possible to provide a link that takes the user directly to a page where a new pull request is created. With github, this would look like:

https://github.com/jeremiah-corrado/mason-registry/pull/new/<PackageName>