Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRIU build fails on s390x #2582

Open
adrianreber opened this issue Feb 4, 2025 · 0 comments · May be fixed by #2590
Open

CRIU build fails on s390x #2582

adrianreber opened this issue Feb 4, 2025 · 0 comments · May be fixed by #2590

Comments

@adrianreber
Copy link
Member

Just saw that building CRIU with the latest vdso changes is failing on s390x:

criu/pie/util-vdso.c: In function ‘elf_symbol_lookup’:
criu/pie/util-vdso.c:313:31: error: initialization of ‘uint32_t *’ {aka ‘unsigned int *’} from incompatible pointer type ‘Hash_t *’ {aka ‘long unsigned int *’} [-Wincompatible-pointer-types]
  313 |                 uint32_t *h = bucket + nbucket + (j - sym_off);
      |                               ^~~~~~
At top level:
cc1: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
make[2]: *** [/builddir/build/BUILD/criu-3.19/scripts/nmk/scripts/build.mk:119: criu/pie/util-vdso.o] Error 1

I haven't had the time to look into it, yet.

CC: @0x7f454c46
@0x7f454c46 0x7f454c46 linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vdso: handle s390x correctly adrianreber/criu
1 participant
@adrianreber