-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesigned app settings and switch to rust crypto #1988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview: https://1988--pr-cinny.netlify.app |
9 tasks
9 tasks
LevitatingBusinessMan
added a commit
to LevitatingBusinessMan/cinny
that referenced
this pull request
Jan 29, 2025
This didn't work correctly, instead we will wait for cinnyapp#1988 This reverts commit 47e48e2, reversing changes made to 62f4c2b.
Could this be an opportunity to add a setting for full body web notifications? Adding the functionality would look something like this: diff --git a/src/app/pages/client/ClientNonUIFeatures.tsx b/src/app/pages/client/ClientNonUIFeatures.tsx
index b257d7a..8678e61 100644
--- a/src/app/pages/client/ClientNonUIFeatures.tsx
+++ b/src/app/pages/client/ClientNonUIFeatures.tsx
@@ -146,19 +146,17 @@ function MessageNotifications() {
roomName,
roomAvatar,
username,
- message,
}: {
roomName: string;
roomAvatar?: string;
username: string;
roomId: string;
eventId: string;
- message: string;
}) => {
- const noti = new window.Notification(`${username} in ${roomName}`, {
+ const noti = new window.Notification(roomName, {
icon: roomAvatar,
badge: roomAvatar,
- body: message,
+ body: `New inbox notification from ${username}`,
silent: true,
});
@@ -180,7 +178,7 @@ function MessageNotifications() {
}, []);
useEffect(() => {
- const handleTimelineEvent: RoomEventHandlerMap[RoomEvent.Timeline] = async (
+ const handleTimelineEvent: RoomEventHandlerMap[RoomEvent.Timeline] = (
mEvent,
room,
toStartOfTimeline,
@@ -217,8 +215,6 @@ function MessageNotifications() {
if (showNotifications && Notification.permission === 'granted') {
const avatarMxc =
room.getAvatarFallbackMember()?.getMxcAvatarUrl() ?? room.getMxcAvatarUrl();
- if (mEvent.isEncrypted()) await mEvent.getDecryptionPromise();
- let content = mEvent.getContent();
notify({
roomName: room.name ?? 'Unknown',
roomAvatar: avatarMxc
@@ -227,7 +223,6 @@ function MessageNotifications() {
username: getMemberDisplayName(room, sender) ?? getMxIdLocalPart(sender) ?? sender,
roomId: room.roomId,
eventId,
- message: content.body,
});
} This would fix #1883, various people have shown interest in re-enabling the message body in notifications. |
* update matrix js sdk * remove dead code * use rust crypto * update setPowerLevel usage * fix types * fix deprecated isRoomEncrypted method uses * fix deprecated room.currentState uses * fix deprecated import/export room keys func * fix merge issues in image pack file * fix remaining issues in image pack file * start indexedDBStore * update package lock and vite-plugin-top-level-await * user session settings - WIP * add useAsync hook * add password stage uia * add uia flow matrix error hook * add UIA action component * add options to delete sessions * add sso uia stage * fix SSO stage complete error * encryption - WIP * update user settings encryption terminology * add default variant to password input * use password input in uia password stage * add options for local backup in user settings * remove typo in import local backup password input label * online backup - WIP * fix uia sso action * move access token settings from about to developer tools * merge encryption tab into sessions and rename it to devices * add device placeholder tile * add logout dialog * add logout button for current device * move other devices in component * render unverified device verification tile * add learn more section for current device verification * add device verification status badge * add info card component * add index file for password input component * add types for secret storage * add component to access secret storage key * manual verification - WIP * update matrix-js-sdk to v35 * add manual verification * use react query for device list * show unverified tab on sidebar * fix device list updates * add session key details to current device * render restore encryption backup * fix loading state of restore backup * fix unverified tab settings closes after verification * key backup tile - WIP * fix unverified tab badge * rename session key to device key in device tile * improve backup restore functionality * fix restore button enabled after layout reload during restoring backup * update backup info on status change * add backup disconnection failures * add device verification using sas * restore backup after verification * show option to logout on startup error screen * fix key backup hook update on decryption key cached * add option to enable device verification * add device verification reset dialog * add logout button in settings drawer * add encrypted message lost on logout * fix backup restore never finish with 0 keys * fix setup dialog hides when enabling device verification * show backup details in menu * update setup device verification body copy * replace deprecated method * fix displayname appear as mxid in settings * remove old refactored codes * fix types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1869 #1399 #792 #1979 #1877 #1130 #940 #1308 #1755 #2034 #1535
Type of change
Checklist: