Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback replies & implement intentional mentions #2138

Merged
merged 12 commits into from
Feb 23, 2025

Conversation

nexy7574
Copy link
Contributor

@nexy7574 nexy7574 commented Jan 5, 2025

Description

This PR removes fallback replies from messages, and additionally adds m.mentions support to Cinny.

Fallback replies simply just aren't used anymore, and m.mentions works by iterating through the children of the composer to find where tabbed-in mentions have been used, and adds those to the mentions dictionary.

This means that cinny no longer accidentally pings anyone who was mentioned in messages that are being replied to.

Fixes #1544

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code (has been deployed in several places for a month)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

github-actions bot commented Jan 10, 2025

Preview: https://2138--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@ajbura
Copy link
Member

ajbura commented Jan 10, 2025

Internal mention also needed to be added in MessageEditor.

..., don't mention the reply author when the reply author is ourself, don't add own user IDs when mentioning intentionally
@ajbura
Copy link
Member

ajbura commented Feb 16, 2025

@nexy7574 are you still working on it? considering you have not requested review and code contains TODO

@nexy7574
Copy link
Contributor Author

@ajbura I've pushed this quite far back in my list of priorities now since I don't really use Cinny all that much anymore, and I've found myself rather busy with life (mainly my education) so haven't had much time to get through the backlog.
I can't say I'll be able to get to this any time soon, but you're welcome to push to my branch or just close the PR for the time being if that is more desireable.

@ajbura
Copy link
Member

ajbura commented Feb 23, 2025

@nexy7574, thanks for your work so far! Since you've already handled most of it, I think it would be best if I push to your branch and take care of the remaining concerns.

Thanks again for your contributions!

@ajbura ajbura requested a review from kfiven February 23, 2025 08:07
@kfiven kfiven merged commit 8d95758 into cinnyapp:dev Feb 23, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add m.mentions to user when replying to a message
3 participants