-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fallback replies & implement intentional mentions #2138
Remove fallback replies & implement intentional mentions #2138
Conversation
(WIP) the typing on line 301 and 303 needs fixing but apart from that this is mint
…/remove-fallback-replies
Preview: https://2138--pr-cinny.netlify.app |
Internal mention also needed to be added in |
..., don't mention the reply author when the reply author is ourself, don't add own user IDs when mentioning intentionally
@nexy7574 are you still working on it? considering you have not requested review and code contains TODO |
@ajbura I've pushed this quite far back in my list of priorities now since I don't really use Cinny all that much anymore, and I've found myself rather busy with life (mainly my education) so haven't had much time to get through the backlog. |
@nexy7574, thanks for your work so far! Since you've already handled most of it, I think it would be best if I push to your branch and take care of the remaining concerns. Thanks again for your contributions! |
Description
This PR removes fallback replies from messages, and additionally adds
m.mentions
support to Cinny.Fallback replies simply just aren't used anymore, and
m.mentions
works by iterating through the children of the composer to find where tabbed-in mentions have been used, and adds those to the mentions dictionary.This means that cinny no longer accidentally pings anyone who was mentioned in messages that are being replied to.
Fixes #1544
Type of change
Checklist: