Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected objects crash cinny #2174

Closed
nexy7574 opened this issue Jan 21, 2025 · 1 comment · Fixed by #2182
Closed

Unexpected objects crash cinny #2174

nexy7574 opened this issue Jan 21, 2025 · 1 comment · Fixed by #2182

Comments

@nexy7574
Copy link
Contributor

Describe the bug

Unexpected values in events, where strings are expected, will cause cinny to crash, seemingly because it tries to render them.

For example,

{"body": {"foo": "bar"}, "msgtype": "m.text"} // message event
{"displayname": {}}  // avatar event

This causes cinny to crash: t.match is not a function

Reproduction

Send an invalid event, such as m.room.message + {"body": {}, "msgtype": "m.text"}. This instantly and persistently crashes cinny until the offending event is removed.

Expected behavior

Cinny would display an error, such as the "unsupported event" one used for unsupported events.

Platform and versions

Windows 10, Firefox, Cinny 4.2.3, nexy7574.co.uk

Additional context

No response

@nexy7574
Copy link
Contributor Author

Looks like the message content handles this appropriately, but the membership still causes issues with the timeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant