-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authsource must be of type saml:SP #100
Comments
Hi @obdeijn , We are using the module with SSP 2.3.0. |
Thanks for you reply @pradtke. I am using the Filesender project (https://github.com/filesender/filesender) which relies on SSP for authentication. I am running it in a Docker container. I have this in the Dockerfile to install the authoauth2 module:
In config/config.php of SSP I have this:
In config/authsources.php of SSP I have this:
Is this also how you do it, or am I missing something? |
@pradtke have you had a chance to look into this? |
Experiencing the same problem with SimpleSamlPHP |
Based on those links @obdeijn , this is an issue with FileSender and SSP 2, not with this module itself. It seems like FileSender is generating a login url (using an SSP api) that SSP2 no longer supports for non-saml SP. We do not use FileSender so have not run into this issue. I believe @monkeyiq is working on an example project for how to work around this at https://github.com/monkeyiq/sspsmall The basic workaround is to make an idp in I'm not familiar with the FileSender login process, but for our own apps we just call the |
I am coming in on the other side, knowledge of FileSender and SSP but not of this module. I have seen the
message, specifically when an attempt was made to pass an access method to the Simple API of SSP. In the 1.x days SSP would accept that and authenticate with the access method and return. In 2.x of SSP I have found that there are some checks in place to make sure you come in as an SP in the simple API. If you try to put something like I made sspsmall to try to help folks get around that must be SP error when they are not so familiar with SAML/SSP. The sspsmall is still a work in progress and I added a second SP for testing SLO which needs to be separated out from a default sspsmall setup. The README, scripts and config/metadata files in sspsmall should still be informative at this stage about how things want to be setup in order to allow an In testing I have also found disabling this exception and creating a small method that is assumed in the SP instance in the auth method class allowed a direct hit on the AM instead of the SP. But that is really untested other than it seems to work on a desktop machine and may cause problems, be insecure, or break in a real world case. I think the requirement to use the SP was added to avoid people being able to directly access an auth method which is then network exposed. For example folks exposing an LDAP server to the net through a direct auth method setup in SSP. |
The README and the provided documentation in https://github.com/cirrusidentity/simplesamlphp-module-authoauth2/blob/master/docs/GOOGLE.md seem to suggest that you can configure an Oauth2 or OpenIDConnect provider directly in authsources.php. This is what we did when we were using SimpleSaml < 2.0 and it worked fine. When I try this now, when upgrading to SimpleSaml 2.3.0 and authoauth2 4.1.0, I get the following error:
SimpleSAML\Error\Exception: Authsource must be of type saml:SP
It seems that this is not an accepted way of configuring an IdP anymore. See also the discussion in simplesamlphp/simplesamlphp#2143 and the documentation in https://simplesamlphp.org/docs/stable/simplesamlphp-sp.html
So it seems to me that the latest version of authoauth2 and the provided documentation is not compatible with SimpleSaml >= 2.0
The text was updated successfully, but these errors were encountered: