Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date-time pickers #405

Closed
classilla opened this issue Jun 18, 2017 · 6 comments
Closed

Implement date-time pickers #405

classilla opened this issue Jun 18, 2017 · 6 comments

Comments

@classilla
Copy link
Owner

@classilla
Copy link
Owner Author

@classilla
Copy link
Owner Author

@classilla
Copy link
Owner Author

Current plan:

  • Create as a regular text box.
  • On click, programmatically open a date panel (like ComplexTextInputPanel.mm with an NSDatePicker
  • Fill the box with YYYY-MM-DD

This should be enough to emulate the current behaviour.

@classilla
Copy link
Owner Author

diff --git a/dom/html/HTMLInputElement.cpp b/dom/html/HTMLInputElement.cpp
index 9e544bd3b..15434e08a 100644
--- a/dom/html/HTMLInputElement.cpp
+++ b/dom/html/HTMLInputElement.cpp
@@ -2958,6 +2958,12 @@ HTMLInputElement::Select()
     return NS_OK;
   }
 
+#if(1)
+  if (mType == NS_FORM_INPUT_DATE) {
+    fprintf(stderr, "Date picker selected, call SetUserInput when ready\n");
+  }
+#endif
+
   if (!IsSingleLineTextControl(false)) {
     return NS_OK;
   }

@classilla
Copy link
Owner Author

The pickers are initialized in HTMLInputElement::MaybeInitPickers.

classilla added a commit that referenced this issue Mar 19, 2018
classilla added a commit that referenced this issue May 31, 2018
classilla added a commit that referenced this issue Jun 15, 2018
classilla added a commit that referenced this issue Jun 26, 2018
classilla added a commit that referenced this issue Jun 29, 2018
classilla added a commit that referenced this issue Jul 2, 2018
classilla added a commit that referenced this issue Jul 3, 2018
classilla added a commit that referenced this issue Jul 3, 2018
@classilla
Copy link
Owner Author

This can be closed in lieu of the followup issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant