From dfeaa5898df7ca90664eecbc5de5c88b20c36885 Mon Sep 17 00:00:00 2001
From: Alessandro Ghedini <alessandro@ghedini.me>
Date: Mon, 15 Jan 2024 13:03:59 +0000
Subject: [PATCH] remove ProtocolViolation error

Follow-up to 1684118a979276428ce9f994b028463b26465698.

This error was added in the previous commit, but we can use a more
specific error instead, also to be more consistent with existing code
(e.g. see HANDSHAKE_DONE case).
---
 quiche/src/lib.rs | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/quiche/src/lib.rs b/quiche/src/lib.rs
index 720b457a96..a6788c3e60 100644
--- a/quiche/src/lib.rs
+++ b/quiche/src/lib.rs
@@ -567,9 +567,6 @@ pub enum Error {
 
     /// Error in key update.
     KeyUpdate,
-
-    /// Protocol error.
-    ProtocolViolation,
 }
 
 impl Error {
@@ -583,7 +580,6 @@ impl Error {
             Error::StreamLimit => 0x4,
             Error::FinalSize => 0x6,
             Error::KeyUpdate => 0xe,
-            Error::ProtocolViolation => 0xa,
             _ => 0xa,
         }
     }
@@ -610,7 +606,6 @@ impl Error {
             Error::IdLimit => -17,
             Error::OutOfIdentifiers => -18,
             Error::KeyUpdate => -19,
-            Error::ProtocolViolation => -20,
         }
     }
 }
@@ -6823,7 +6818,7 @@ impl Connection {
             // TODO: implement stateless retry
             frame::Frame::NewToken { .. } =>
                 if self.is_server {
-                    return Err(Error::ProtocolViolation);
+                    return Err(Error::InvalidPacket);
                 },
 
             frame::Frame::Stream { stream_id, data } => {
@@ -12284,7 +12279,7 @@ mod tests {
 
         assert_eq!(
             pipe.server_recv(&mut buf[..written]),
-            Err(Error::ProtocolViolation)
+            Err(Error::InvalidPacket)
         );
     }