You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're currently failing a lot of the WPT tests for url encoding, not because we're doing anything wrong with regard to url encoding, but because we disallow the made-up HTTP method they're using:
This would require some deep changes to the KJ HTTP implementation, which uses an enum for HTTP methods. Meanwhile, to my knowledge no one has ever requested support for method names outside our list, so changing it just for some contrived tests feels like a tough sell.
I wonder if we could just... add LADIDA to the enum... lol.
... Meanwhile, to my knowledge no one has ever requested support for method names outside our list
If we can use Node.js' past history here as a guide... folks are simply unlikely to ask. Folks would just try, see that it wouldn't work, then go do something else instead. It wasn't until after we enabled arbitrary http method that we actually started to see folks trying to use them.
In any case, I don't think this is actionable at all right now (or even needs to be). The wpt test in question can just be skipped.
We're currently failing a lot of the WPT tests for url encoding, not because we're doing anything wrong with regard to url encoding, but because we disallow the made-up HTTP method they're using:
We don't need to take any action now, but I'm just raising this as a data point for allowing arbitrary method names.
cc: @jasnell, @kentonv
The text was updated successfully, but these errors were encountered: