f

Author: fengmk2

app/common/typing.ts

@@ -72,6 +72,9 @@ export interface AuthClient {
 }
 
 declare module 'egg' {
+  // eslint-disable-next-line
+  // @ts-ignore
+  // avoid TS2310 Type 'EggAppConfig' recursively references itself as a base type.
   interface EggAppConfig {
     cnpmcore: CnpmcoreConfig;
   }

app/port/controller/PackageSyncController.ts

@@ -59,7 +59,6 @@ export class PackageSyncController extends AbstractController {
     if (!this.enableSync) {
       throw new ForbiddenError('Not allow to sync package');
     }
-    // @ts-expect-error should auto import tracer plugin
     const tips = data.tips || `Sync cause by "${ctx.href}", parent traceId: ${ctx.tracer.traceId}`;
     const isAdmin = await this.userRoleManager.isAdmin(ctx);
 
@@ -183,7 +182,6 @@ export class PackageSyncController extends AbstractController {
   async deprecatedCreateSyncTask(@Context() ctx: EggContext, @HTTPParam() fullname: string, @HTTPQuery() nodeps: string) {
     const options: SyncPackageTaskType = {
       fullname,
-      // @ts-expect-error should auto import tracer plugin
       tips: `Sync cause by "${ctx.href}", parent traceId: ${ctx.tracer.traceId}`,
       skipDependencies: nodeps === 'true',
       syncDownloadData: false,

app/port/middleware/Tracing.ts

@@ -11,8 +11,6 @@ export async function Tracing(ctx: EggContext, next: Next) {
   //   host: 'localhost:7001',
   //   connection: 'keep-alive'
   // }
-  // TODO: fix type
-  // @ts-expect-error should auto import tracer plugin
   ctx.set('request-id', ctx.tracer.traceId);
   if (ctx.method !== 'HEAD') {
     ctx.logger.info('[Tracing] auth: %s, npm-command: %s, referer: %s, user-agent: %j',