Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: clarification on hashed password #6114

Closed
j4ys0n opened this issue Mar 28, 2023 · 3 comments
Closed

[Docs]: clarification on hashed password #6114

j4ys0n opened this issue Mar 28, 2023 · 3 comments
Labels
docs Documentation related

Comments

@j4ys0n
Copy link

j4ys0n commented Mar 28, 2023

What is your suggestion?

Please mention that if you're entering the hashed password in a docker-compose yaml file that the $ need to be escaped like $$ or else docker will interpret them as variable markers. Also mention that the password should not be contained in quotes.

How will this improve the docs?

Hashed password will work with more run environments

Are you interested in submitting a PR for this?

Sure

@j4ys0n j4ys0n added the docs Documentation related label Mar 28, 2023
@benz0li
Copy link
Contributor

benz0li commented Mar 30, 2023

That is not code-server specific and already described here: https://docs.docker.com/compose/compose-file/12-interpolation/

@j4ys0n
Copy link
Author

j4ys0n commented Mar 30, 2023

Yes, you are correct. It would be nice to include that information as it is relevant. Just my opinion.

@code-asher
Copy link
Member

code-asher commented Jul 13, 2024

Maybe this was added later, but we do mention this in the docs at the moment.

Edit: yeah it was added later #6671

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

No branches or pull requests

3 participants